refactor(datepicker): avoid frequent template expressions re-evaluati…#1806
Merged
chintankavathia merged 1 commit intomainfrom Apr 9, 2026
Merged
refactor(datepicker): avoid frequent template expressions re-evaluati…#1806chintankavathia merged 1 commit intomainfrom
chintankavathia merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the calendar body to use a computed signal for managing cell range CSS classes, replacing multiple individual class bindings in the template. A performance concern was raised regarding the cellRangeClasses signal, which currently triggers re-calculations on every mouse movement because it unconditionally depends on the activeHover signal. It is recommended to read the hover signal conditionally to avoid unnecessary updates when range selection or previews are disabled.
spliffone
force-pushed
the
refactor/calendar-body-cache
branch
2 times, most recently
from
7b54faa to
8b19335
Compare
chintankavathia
requested changes
Apr 8, 2026
chintankavathia
requested changes
Apr 8, 2026
…on in si-calendar-body
spliffone
force-pushed
the
refactor/calendar-body-cache
branch
from
8b19335 to
66bc0b9
Compare
chintankavathia
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on in si-calendar-body
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: